Add initial support for operating with workflows - #23
Draft
tuommaki wants to merge 10 commits into
Draft
Conversation
Workflows are the main objects that provide the platform computation functionality. Workflow tasks convert on-chain into individual tasks, but the overall coordination of execution happens by the rules described in the workflow. This change adds basic CRUD support for workflows.
tuommaki
commented
Nov 15, 2024
| use anyhow::{Context, Result}; | ||
| use log::debug; | ||
| use gevulot_rs::runtime_config::{self, RuntimeConfig}; | ||
| use mia_installer::runtime_config::{self, RuntimeConfig}; |
Contributor
Author
There was a problem hiding this comment.
This fixes the build now that gevulot-rs is changing.
tuommaki
commented
Nov 15, 2024
| pub async fn get_pin(_sub_m: &clap::ArgMatches) -> Result<(), Box<dyn std::error::Error>> { | ||
| let mut client = connect_to_gevulot(_sub_m).await?; | ||
| if let Some(pin_cid) = _sub_m.get_one::<String>("cid") { | ||
| let mut client = connect_to_gevulot(_sub_m).await?; |
Contributor
Author
There was a problem hiding this comment.
Instantiate client only after the CLI argument has been validated 🙂
…/gvltctl into add-support-for-workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflows are the main objects that provide the platform computation functionality. Workflow tasks convert on-chain into individual tasks, but the overall coordination of execution happens by the rules described in the workflow.
This change adds basic CRUD support for workflows.