deps: Update pdb-addr2line to 0.12.0#1018
Merged
Merged
Conversation
This change is long past due. By doing this, we move from our unmaintained `pdb` crate to the maintained `pdb2` fork (https://crates.io/crates/pdb2). As afranchuk/pdb@master...getsentry:pdb:master shows, `pdb` contains no significant changes that `pdb2` doesn't have.
loewenheim
force-pushed
the
sebastian/pdb-addr2line
branch
from
July 16, 2026 10:55
8af8df6 to
054e84e
Compare
loewenheim
commented
Jul 16, 2026
Contributor
Author
There was a problem hiding this comment.
RwLock/Mutex changes in this file are down to the fact that pdb_addr2line::TypeFormatter::new_from_parts now requires its first parameter to be Sync.
|
|
||
| // Used for CFI, remove once abstraction is complete | ||
| #[doc(hidden)] | ||
| pub use pdb_addr2line::pdb; |
Contributor
Author
There was a problem hiding this comment.
The fact that we're exposing pdb here, as well as the hidden inner method down below, strictly speaking make this a breaking change.
Member
There was a problem hiding this comment.
LOL "remove once abstraction is complete" looks like an old comment.
jjbayer
approved these changes
Jul 16, 2026
|
|
||
| // Used for CFI, remove once abstraction is complete | ||
| #[doc(hidden)] | ||
| pub use pdb_addr2line::pdb; |
Member
There was a problem hiding this comment.
LOL "remove once abstraction is complete" looks like an old comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is long past due. By doing this, we move from our unmaintained
pdbcrate to the maintainedpdb2fork (https://crates.io/crates/pdb2). As afranchuk/pdb@master...getsentry:pdb:master shows,pdbcontains no significant changes thatpdb2doesn't have.