feat(minidump): Shed large attachments#5970
Open
tobias-wilfert wants to merge 8 commits intomasterfrom
Open
Conversation
tobias-wilfert
commented
May 11, 2026
| field: Field<'static>, | ||
| mut item: Managed<Item>, | ||
| config: &Config, | ||
| ignore_size_exceeded: bool, |
Member
Author
There was a problem hiding this comment.
This already did some similar logic to what we wanted but could not be used to skip over only large attachments but not large minidumps.
jjbayer
reviewed
May 11, 2026
jjbayer
reviewed
May 11, 2026
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
…om:getsentry/relay into tobias-wilfert/feat/skip-large_attachments
jjbayer
approved these changes
May 11, 2026
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the logic to skip over large attachments on the
/minidumpendpoint (if they can't be uploaded to objectstore). More concretely if we encounter an attachment that is too large to put it in the envelope, instead of dropping everything, only drop the attachment and proceed with the remaining items. This is done to avoid dropping the minidump if it is send along with large attachments.Fix: INGEST-876