Use pre-built images for nginx & service containers#895
Conversation
|
Latest thinking doc. @alxndrsn will revise this PR in light of those thoughts and describe how each end-user goal is met by the proposed approach. |
I think this is correct. To tackle this I have:
|
Is there any risk of breaking these peoples' existing deployments? Would it be better for existing commands to continue building locally, and add new recommended commands which use pre-built images? |
It would definitely be annoying for them. But if they're modifying source we know they have technical capacity and as long as we document a process I think it's ok.
Can you elaborate a bit on what that would look like? When you say commands, do you mean |
Yes, so in this scenario the existing I don't think this necessarily simplifies things though, so I'm relieved you said this:
|
|
@alxndrsn, just wanted to check whether there are any outstanding questions here. Are you blocked by anything? Once we get v2025.1 out the door, I'd be happy to meet/pair on this PR. I'm familiar with our release process(es) and how the different repos work, so I think I can add any context that's missing. |
TODO
Related to #677
What's changed?
docker-compose.ymlnow referencesserviceandnginxcontainers by specific version numberdocker-compose.yml. If preferred, this could be converted to documentationWhat has been done to verify that this works as intended?
docker compose buildlocally, and watched the results:Why is this the best possible solution? Were any other approaches considered?
TODO
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)