Skip to content

feat: add flag to define whether approval only from the author from is enough#17

Draft
Mariusz Wojakowski (mariusz89016) wants to merge 1 commit into
mainfrom
allow-author-approval-option
Draft

feat: add flag to define whether approval only from the author from is enough#17
Mariusz Wojakowski (mariusz89016) wants to merge 1 commit into
mainfrom
allow-author-approval-option

Conversation

@mariusz89016

Copy link
Copy Markdown
Contributor

No description provided.

@mariusz89016 Mariusz Wojakowski (mariusz89016) changed the title feat: Add flag to define whether approval only from the author from is enough feat: add flag to define whether approval only from the author from is enough Mar 14, 2023
@github-actions

Copy link
Copy Markdown

Checkov

check_id file resource check_name guideline
0 CKV_DOCKER_2 /app/Dockerfile /app/Dockerfile. Ensure that HEALTHCHECK instructions have been added to container images https://docs.bridgecrew.io/docs/ensure-that-healthcheck-instructions-have-been-added-to-container-images

@github-actions

Copy link
Copy Markdown

Trivy

PkgName InstalledVersion Severity Title CVE URL
curl 7.87.0-r1 CRITICAL curl: HSTS ignored on multiple requests https://avd.aquasec.com/nvd/cve-2023-23914

MERGE_REQUEST_AUTHOR=$(jq -rn --arg x "${REPO_NAME}" '$x|@uri' | xargs -i glab api projects/{}/merge_requests/$PULL_NUM | jq '.author.username')

if [ "${RESULT[*]}" == "$MERGE_REQUEST_AUTHOR" ] && [ "$ALLOW_AUTHOR_APPROVAL" == "false" ]; then
printf "MR approved only by the author - will not continue...\n"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
printf "MR approved only by the author - will not continue...\n"
printf "MR approved only by the author - merge has been canceled.\n"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants