Migrate desktop packaging to electron-builder#24
Merged
Conversation
Move desktop packaging to an electron-builder-first flow, keep only a thin Go daemon build wrapper, add a dedicated desktop release workflow, and replace the bespoke mac packaging path with builder-native DMG/signing configuration.
Trim mac Electron locales down to the English and Chinese variants we actually want to ship, and disable the extra strict verification pass during signing so notarized desktop builds spend less time in code-sign processing.
Drop the redundant custom ref input in favor of GitHub's built-in workflow source selection, require a v-prefixed source ref for publish=true, and ignore the local electron/cred credentials directory so signing material stays untracked.
Allow the desktop release workflow to trigger on pushes to electron-builder-migration for branch-level validation, while treating branch pushes as build-only runs and keeping actual publish behavior reserved for v-prefixed tag refs.
Drop the temporary push trigger for electron-builder-migration now that GitHub has registered the desktop workflow. Keep the workflow discoverable in Actions while limiting automatic runs back to v-prefixed tag pushes and manual dispatches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
electron/electron-builder.ymlelectron/scripts/dist-mac.cjsflowelectron/scripts/build-desktop.cjswrapper that:electron-builderelectron/scripts/set-desktop-version.cjsfor CI version injectionelectron/build/