Skip to content

fix: Include directory when parsing context location#954

Merged
dustinbyrne merged 3 commits into
developfrom
feat/update-open-location
Apr 29, 2024
Merged

fix: Include directory when parsing context location#954
dustinbyrne merged 3 commits into
developfrom
feat/update-open-location

Conversation

@dustinbyrne

@dustinbyrne dustinbyrne commented Apr 29, 2024

Copy link
Copy Markdown
Contributor

@dustinbyrne dustinbyrne requested a review from ahtrotta April 29, 2024 14:09
@ahtrotta

Copy link
Copy Markdown
Contributor

I re-ran the integration tests and a different one failed, so it seems like they're suddenly unstable again. Both failing tests had to do with expecting tree providers to have the expected tree items.

@kgilpin

kgilpin commented Apr 29, 2024

Copy link
Copy Markdown
Contributor

I re-ran the integration tests and a different one failed, so it seems like they're suddenly unstable again. Both failing tests had to do with expecting tree providers to have the expected tree items.

FYI tree provider has a known bug - #930

@ahtrotta ahtrotta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and worked well when I tested it manually in a workspace with multiple project folders 👍

@dustinbyrne dustinbyrne force-pushed the feat/update-open-location branch from 8259243 to 914d42d Compare April 29, 2024 19:13
@dustinbyrne dustinbyrne marked this pull request as ready for review April 29, 2024 19:13
@dustinbyrne dustinbyrne merged commit 442c94e into develop Apr 29, 2024
@dustinbyrne dustinbyrne deleted the feat/update-open-location branch April 29, 2024 19:13
@appland-release

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.118.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants