feat: add download button for latest SCB file in backup setting#1803
Draft
ajaysehwal wants to merge 1 commit intogetAlby:masterfrom
Draft
feat: add download button for latest SCB file in backup setting#1803ajaysehwal wants to merge 1 commit intogetAlby:masterfrom
ajaysehwal wants to merge 1 commit intogetAlby:masterfrom
Conversation
ajaysehwal
force-pushed
the
scb-download-button
branch
from
7afa128 to
d047537
Compare
Member
|
@ajaysehwal can you also test this in HTTP mode? it doesn't work for me. |
rolznz
reviewed
Oct 14, 2025
| readOnlyApiGroup.GET("/swaps/mnemonic", httpSvc.swapMnemonicHandler) | ||
| readOnlyApiGroup.GET("/autoswap", httpSvc.getAutoSwapConfigHandler) | ||
| readOnlyApiGroup.GET("/forwards", httpSvc.forwardsHandler) | ||
| readOnlyApiGroup.GET("/scb/latest", httpSvc.getLatestSCBHandler) |
Member
There was a problem hiding this comment.
we shouldn't need this endpoint. The frontend just calls this one to call another endpoint. The /scb/download endpoint can handle it all.
rolznz
reviewed
Oct 14, 2025
| return nil, fmt.Errorf("failed to get absolute workdir: %w", err) | ||
| } | ||
|
|
||
| backupDirectory := filepath.Join(workDir, "static_channel_backups") |
Member
There was a problem hiding this comment.
This doesn't get the correct directory. I'm not sure how this worked for you in the demo video?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1037
Screen.Recording.2025-10-05.at.6.07.40.PM.mov