chore: update to better-auth 1.6.15, minimum 1.6.11#388
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: get-convex/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates better-auth versions across the repo: bumps devDependencies for better-auth, Possibly related PRs
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/content/docs/migrations/migrate-to-0-12.mdx`:
- Line 22: Update the migration guide sentence that currently states “Better
Auth must be on 1.6.9” to read “Better Auth must be on 1.6.11” so it matches the
package.json peer range (>=1.6.11 <1.7.0); leave the existing npm install pin
line (`npm install better-auth@~1.6.15`) unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: get-convex/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ff81f268-4cd1-48e8-93e9-bf0c83044750
⛔ Files ignored due to path filters (4)
examples/next/package-lock.jsonis excluded by!**/package-lock.jsonexamples/react/package-lock.jsonis excluded by!**/package-lock.jsonexamples/tanstack/package-lock.jsonis excluded by!**/package-lock.jsonpackage-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (7)
docs/content/docs/framework-guides/expo.mdxdocs/content/docs/framework-guides/next.mdxdocs/content/docs/framework-guides/react.mdxdocs/content/docs/framework-guides/sveltekit.mdxdocs/content/docs/framework-guides/tanstack-start.mdxdocs/content/docs/migrations/migrate-to-0-12.mdxpackage.json
| ```npm | ||
| npm install @convex-dev/better-auth@^0.12.0 | ||
| npm install better-auth@~1.6.9 | ||
| npm install better-auth@~1.6.15 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify mismatched Better Auth minimum/version references in docs vs package contract.
rg -n -C2 '1\.6\.9|1\.6\.11|better-auth@\~1\.6\.15' docs/content/docs
rg -n -C2 '"better-auth":\s*">=1\.6\.11 <1\.7\.0"' package.jsonRepository: get-convex/better-auth
Length of output: 2893
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Find all mentions of 1.6.9 in docs
rg -n "1\.6\.9" docs/content/docs
# Show exact context around the migration sentence mentioning 1.6.9
rg -n -C3 "Better Auth must be on `1\.6\.9`" docs/content/docs/migrations/migrate-to-0-12.mdx || true
# Fallback: show lines around first occurrence of 1.6.9 in that file
rg -n -C5 "1\.6\.9" docs/content/docs/migrations/migrate-to-0-12.mdx || true
# Confirm peerDependencies stanza in package.json with context
rg -n -C3 '"better-auth"\s*:\s*">=1\.6\.11 <1\.7\.0"' package.json || trueRepository: get-convex/better-auth
Length of output: 973
Update the documented Better Auth minimum version in the 0.12 migration guide
In docs/content/docs/migrations/migrate-to-0-12.mdx, the text says “Better Auth must be on 1.6.9…”, but package.json peer range is "better-auth": ">=1.6.11 <1.7.0". Update that minimum-version sentence to 1.6.11 (the npm install better-auth@~1.6.15 pin can remain).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/content/docs/migrations/migrate-to-0-12.mdx` at line 22, Update the
migration guide sentence that currently states “Better Auth must be on 1.6.9” to
read “Better Auth must be on 1.6.11” so it matches the package.json peer range
(>=1.6.11 <1.7.0); leave the existing npm install pin line (`npm install
better-auth@~1.6.15`) unchanged.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/test/adapter-factory/convex-custom.ts (1)
430-452: ⚡ Quick winAdd a companion regression assertion for
wherebeing undefined/missing.This test locks in
where: [], but the adapter guard is!data.where?.length(so undefined/missing is also part of the contract). Add one more assertion to cover that path explicitly.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/test/adapter-factory/convex-custom.ts` around lines 430 - 452, Add a sibling assertion to the existing test that covers the case where the update `where` is undefined (missing) in addition to the empty array case: call adapter.update with the same model and update payload but omit the `where` key entirely and assert it returns null and that the record was not modified (use adapter.findOne with the original user's id to verify equality). Update the test named "should return null and not modify records when update where is empty" to include this extra check so it exercises the adapter.guard condition `!data.where?.length`.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/test/adapter-factory/convex-custom.ts`:
- Around line 430-452: Add a sibling assertion to the existing test that covers
the case where the update `where` is undefined (missing) in addition to the
empty array case: call adapter.update with the same model and update payload but
omit the `where` key entirely and assert it returns null and that the record was
not modified (use adapter.findOne with the original user's id to verify
equality). Update the test named "should return null and not modify records when
update where is empty" to include this extra check so it exercises the
adapter.guard condition `!data.where?.length`.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: get-convex/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7550212e-0a57-4983-a88d-53d1c04314a4
📒 Files selected for processing (2)
src/client/adapter.tssrc/test/adapter-factory/convex-custom.ts
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 participant
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.