Resolve the mechanical findings F68-F73 and F76 - #194
Merged
Conversation
- F68: delete the dead src/poe/endpoints/website/ directory and its CMakeLists.txt entries (no includers anywhere; two headers defined types under filenames that promised something else). - F69: delete the dead Shop::StashesIndexed signal declaration. - F70: reword the "Failed to find item" recovery advice in Shop::OnShopSubmitted - it pointed at a Shop menu action that no longer exists; the recovery is simply resubmitting. - F71: mask the bearer token in NetworkManager::createRequest's trace log, matching how setPoeSessionId masks POESESSID. - F72: fix the Authorization mask in NetworkManager::logHeaders to compare the header name instead of the "request"/"reply" label, so it can actually fire. - F73: keep glz::format_error's buffer context out of log lines whose source buffer can carry a token - OAuthManager::receiveToken formats the error without the buffer, and read_json gains a buffer_may_hold_credentials flag (set by readOAuthToken) that logs the error code and byte position only. - F76: delete the dead OAuthManager::m_authenticated / isAuthenticatedChanged and the never-connected LoginDialog::OnSessionIDChanged. findings.md: the six entries move to the resolved ledger; F74's opener now names the credential-custody investigation directly since it no longer follows F71-F73. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Copy the crashpad handler from $<TARGET_FILE:crashpad_handler> instead of a hardcoded single-config path, and give acquisition an explicit dependency on the handler target. Multi-config generators (e.g. the Visual Studio default that plain `cmake -S . -B build` picks on Windows) put the handler under a per-config subdirectory, which broke the POST_BUILD copy. Under Ninja the expression resolves to the same path CI uses today. - Prepend Qt's bin directory to PATH for the registered tests on Windows via ENVIRONMENT_MODIFICATION, so `ctest --test-dir build` works from a plain shell instead of failing with 0xc0000135. CI already has Qt on PATH (install-qt-action), where the prepend is a no-op. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Seems like a solid cleanup! Good dead code removal and build portability / windows stuff |
gerwaric
added a commit
that referenced
this pull request
Aug 9, 2026
Patch release staging for the fixes on master since v0.18.0: the buyout price formatting fix (#150), the F30 pacing-message downgrade, the PR #193 cleanups, and the PR #194 mechanical credential-safety findings (F68-F73, F76). Cut ahead of merging PR #192 so the 0.19.0-alpha.1 feature release stays separate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the seven mechanical open findings from the shop write-path and credential-custody investigations, plus two build fixes discovered while validating them.
Findings sweep (F68-F73, F76)
src/poe/endpoints/website/directory (no includers anywhere; two headers defined types under filenames that promised something else) and itsCMakeLists.txtentries.Shop::StashesIndexedsignal declaration.Shop::OnShopSubmitted— it pointed at a Shop menu action that no longer exists; the recovery is simply resubmitting.NetworkManager::createRequest's trace log, matching howsetPoeSessionIdmasks POESESSID.NetworkManager::logHeadersto compare the header name instead of the "request"/"reply" label, so it can actually fire.glz::format_error's buffer context out of log lines whose source buffer can carry a token —OAuthManager::receiveTokenformats the error without the buffer, andread_jsongains abuffer_may_hold_credentialsflag (set byreadOAuthToken) that logs the error code and byte position only. (This glaze version exposes the position aserror_ctx::count, notlocation.)OAuthManager::m_authenticated/isAuthenticatedChangedand the never-connectedLoginDialog::OnSessionIDChanged.docs/cleanup/findings.mdmoves the six entries to the resolved ledger per the register's convention; F74, F75, and F77 stay open (F74's opener now names the credential-custody investigation directly since it no longer follows F71-F73).Build fixes (separate commit)
$<TARGET_FILE:crashpad_handler>instead of a hardcoded single-config path, with an explicitadd_dependencies. Multi-config generators (the Visual Studio default a plaincmake -S . -B buildpicks on Windows) put the handler under a per-config subdirectory, which broke the POST_BUILD copy. Under Ninja the expression resolves to the same path CI uses today.ENVIRONMENT_MODIFICATION, soctest --test-dir buildworks from a plain shell instead of failing with 0xc0000135. CI already has Qt on PATH (install-qt-action), where the prepend is a no-op.Verification
🤖 Generated with Claude Code