Java17 and modernize#86
Merged
Merged
Conversation
…pdate dependencies
…' into java17-and-modernize
This was
linked to
issues
Jun 16, 2026
This was referenced Jun 18, 2026
HTTPProxy.executeProxyRequest:
- Read the Location header from the response instead of the outgoing
request object (the request never carries it), and null-check the
header before dereferencing it to avoid an NPE on 3xx responses
lacking a Location header.
- Treat 307 (Temporary Redirect) and 308 (Permanent Redirect) as
redirects in addition to 300-303.
- Resolve the status code once into a local instead of calling
getStatusCode(response) repeatedly.
Tests:
- Update testRedirectGet to stub the response's Location header.
- Add testRedirectGet307 covering the newly handled 307 case.
CI: use the 'temurin' distribution in the publish job to match the
build job ('adopt' is a deprecated setup-java alias).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
afabiani
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes stem from the work made from georchestra in #82.
Migrate to Jakarta EE / Apache HttpClient 5 / Java 17, add Docker support
When this get merged, these changes will overseed the ones in #82, that then could be closed.