Merged
Conversation
in my testing, if using a raw string with an r prefix and double quotes here, it wasnt extrapolated by the python code. dont use the r prefix and use single quotes instead. while here, OPTIONS is the right HTTP method, not OPTION
landryb
added a commit
to georchestra/ansible
that referenced
this pull request
Apr 8, 2026
Member
|
Thanks @landryb. Actually this regex strings issue reminds me of something. I don't really understand why in some cases the r prefix is counter-productive. I'll have to investigate this. Good catch for the OPTION(S) issue. About the config files, maybe I'll have to add some doc about this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in my testing, if using a raw string with an
rprefix and double quotes here, it wasn't extrapolated by the python code and used as a string started byr.... so don't use therprefix and use single quotes instead, matches the actual lines produced by the s-p and the gateway.while here,
OPTIONSis the right HTTP method name, notOPTIONi haven't tested/modified the regex string for the opentelemetry parser but maybe it has the same issue.
sidenote: i dunno which file should be used between analytics-cli/config/analytics_cli.yaml and analytics-cli/src/georchestra_analytics_cli/config/analytics_cli.yaml, the first one has less comments and seem to predate the second one.