Skip to content

improve regexp for CLF-like parsing#13

Merged
jeanpommier merged 2 commits intomainfrom
fix/regex
Apr 15, 2026
Merged

improve regexp for CLF-like parsing#13
jeanpommier merged 2 commits intomainfrom
fix/regex

Conversation

@landryb
Copy link
Copy Markdown
Member

@landryb landryb commented Apr 8, 2026

in my testing, if using a raw string with an r prefix and double quotes here, it wasn't extrapolated by the python code and used as a string started by r.... so don't use the r prefix and use single quotes instead, matches the actual lines produced by the s-p and the gateway.

while here, OPTIONS is the right HTTP method name, not OPTION

i haven't tested/modified the regex string for the opentelemetry parser but maybe it has the same issue.

sidenote: i dunno which file should be used between analytics-cli/config/analytics_cli.yaml and analytics-cli/src/georchestra_analytics_cli/config/analytics_cli.yaml, the first one has less comments and seem to predate the second one.

in my testing, if using a raw string with an r prefix and double quotes here, it wasnt extrapolated by the python code. dont use the r prefix and use single quotes instead.

while here, OPTIONS is the right HTTP method, not OPTION
@landryb landryb requested a review from jeanpommier April 8, 2026 11:54
landryb added a commit to georchestra/ansible that referenced this pull request Apr 8, 2026
@jeanpommier
Copy link
Copy Markdown
Member

Thanks @landryb. Actually this regex strings issue reminds me of something. I don't really understand why in some cases the r prefix is counter-productive. I'll have to investigate this.

Good catch for the OPTION(S) issue.

About the config files, maybe I'll have to add some doc about this:

  • analytics-cli/src/georchestra_analytics_cli/config/analytics_cli.yaml provides the default values. It is thought to serve as a reference of what the config files supports
  • analytics-cli/config/analytics_cli.yaml is a sample config file you can call to override the default ones. Maybe I should remove it completely from the repo

@jeanpommier jeanpommier merged commit 3ceec7f into main Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants