Ensure tests pass under MySQL and Postgres - #7
Open
mcmire wants to merge 5 commits into
Open
Conversation
…uccessfully under MySQL
…uccessfully under Postgres Add Postgres as a development dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In trying to fix the :through bug as mentioned in #3, I noticed that a ton of tests were failing under MySQL, so I ensured they passed, and then I did the same thing for Postgres. There were three failing tests which I left alone:
I also ran
bundle updateand committed the new Gemfile.lock, mainly because I was trying to debug some Arel-specific stuff and since the Arel docs are against master it was just easier to ensure I was working with Arel 2. Now that I think about it, Gemfile.lock probably shouldn't be in the repo, at least according to Yehuda, since geokit-rails3 is a gem.