Skip to content

Bugfix distance field - #145

Open
bricesanchez wants to merge 1 commit into
geokit:masterfrom
bricesanchez:bugfix-distance-field
Open

Bugfix distance field#145
bricesanchez wants to merge 1 commit into
geokit:masterfrom
bricesanchez:bugfix-distance-field

Conversation

@bricesanchez

Copy link
Copy Markdown

No description provided.

)
with_latlng
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*")
.order(Arel.sql(distance_column_name).send(options[:reverse] ? 'desc' : 'asc'))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Metrics/LineLength: Line is too long. [89/80]

Arel.sql(distance_column_name).send(options[:reverse] ? 'desc' : 'asc')
)
with_latlng
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Metrics/LineLength: Line is too long. [93/80]

with_latlng
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*")
.where(bound_conditions(bounds))
.where(distance_conditions(options))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.


with_latlng
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*")
.where(bound_conditions(bounds))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.

distance_column_name = distance_sql(origin, units, formula)

with_latlng
.select("#{distance_column_name} AS #{self.distance_column_name}, #{table_name}.*")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/DotPosition: Place the . on the previous line, together with the method call receiver.
Metrics/LineLength: Line is too long. [93/80]

@bricesanchez
bricesanchez force-pushed the bugfix-distance-field branch from 3dd5088 to 3f6bb58 Compare March 7, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants