chore(coderabbit): enable approval workflow pre-merge checks#50
Merged
Conversation
Owner
Author
|
@coderabbitai configuration |
|
Configuration used: Path: .coderabbit.yaml CodeRabbit configuration# Source: Repository YAML (base)
language: en-US
# Source: defaults
tone_instructions: ''
# Source: defaults
early_access: false
# Source: defaults
enable_free_tier: true
# Source: defaults
inheritance: false
reviews:
# Source: Repository YAML (base)
profile: assertive
# Source: Repository YAML (base)
request_changes_workflow: true
# Source: Repository YAML (base)
high_level_summary: true
# Source: defaults
high_level_summary_instructions: ''
# Source: Repository YAML (base)
high_level_summary_placeholder: '`@coderabbitai` summary'
# Source: defaults
high_level_summary_in_walkthrough: false
# Source: Repository YAML (base)
auto_title_placeholder: '`@coderabbitai`'
# Source: defaults
auto_title_instructions: ''
# Source: Repository YAML (base)
review_status: true
# Source: defaults
review_details: false
# Source: defaults
review_progress: true
# Source: defaults
commit_status: true
# Source: defaults
fail_commit_status: false
# Source: Repository YAML (base)
collapse_walkthrough: false
# Source: Repository YAML (base)
changed_files_summary: true
# Source: Repository YAML (base)
sequence_diagrams: true
# Source: defaults
estimate_code_review_effort: true
# Source: defaults
assess_linked_issues: true
# Source: defaults
related_issues: true
# Source: defaults
related_prs: true
# Source: defaults
suggested_labels: true
# Source: defaults
labeling_instructions: []
# Source: defaults
mutually_exclusive_groups: {}
# Source: defaults
auto_apply_labels: false
# Source: defaults
suggested_reviewers: true
# Source: defaults
auto_assign_reviewers: false
# Source: defaults
suggested_reviewers_instructions: []
# Source: defaults
in_progress_fortune: true
# Source: Repository YAML (base)
poem: false
# Source: defaults
enable_prompt_for_ai_agents: true
# Source: Repository YAML (base)
path_filters:
- '!**/*.lock'
- '!**/*.generated.*'
- '!**/dist/**'
- '!**/node_modules/**'
- '!**/*.min.js'
- '!**/coverage/**'
- '!**/__snapshots__/**'
- '!**/playwright-report/**'
- '!**/*.sourcemap'
- '!**/worker/dist/**'
- '!/.cursor/**'
# Source: Repository YAML (base)
path_instructions:
- path: src/domain/geometry/**
instructions: |
Review geometry code for:
- Numerical stability and floating-point edge cases
- Performance (CI runs test:perf when geometry paths change)
- Worker offload correctness and mask union edge cases
- Consistency with combined elimination mask logic
- path: src/domain/**
instructions: |
Review domain code for:
- Game-rule fidelity (src/domain/ is source of truth for app behavior)
- ruleSummary strings are canonical user-facing rule text
- Catalog sync with reference docs when catalogs change
- Read .cursor/skills/game/SKILL.md conventions when mechanics change
- path: src/services/firestore/**
instructions: |
Review Firestore services for:
- Serialization round-trips and schema validation
- Offline write queuing and idempotency
- Parity with firestore.rules validation helpers
- path: firestore.rules
instructions: |
Review security rules for:
- Parity with TypeScript validation (validDisabledTools, validGameSize,
validPlayerRole, admin email in isAdmin())
- Auth checks on all writes
- Keep in sync with src/domain/admin/adminAccess.ts and Functions
- path: src/hooks/sync/**
instructions: |
Review sync hooks for:
- Offline/online transition handling
- Retry and flush ordering
- Race conditions on reconnect
- path: src/services/session/offlineQueue.ts
instructions: |
Review offline queue for:
- Operation ordering and deduplication
- Schema migration compatibility
- Flush failure recovery
- path: functions/**
instructions: |
Review Firebase Functions for:
- Authentication and authorization on callable/HTTP endpoints
- Firestore write safety and error handling
- Sentry error reporting
- Schema parity with client firestoreDocuments
- path: src/components/**
instructions: |
Review UI components for:
- Broadcast HUD design system (DESIGN.md): dark navy surfaces, Barlow
Semi Condensed headings, Source Sans 3 body
- Reuse existing components before new markup
- Accessibility on interactive controls
- path: src/routes/**
instructions: |
Review routes for:
- Session lifecycle and role-based access
- Error boundaries and loading states
- Design system consistency with DESIGN.md
- path: src/styles/**
instructions: |
Review styles for:
- Token usage from DESIGN.md (colors, typography, spacing)
- Motion and reduced-motion preferences
- Avoid hardcoded colors outside design tokens
- path: e2e/**
instructions: |
Review e2e tests for:
- Smoke vs full split (E2E_SMOKE=1 for PR CI)
- Firebase emulator requirement
- Stable waitFor patterns instead of fixed timeouts
- Visual snapshot updates only when intentional
- path: CHANGELOG.md
instructions: |
Review changelog for:
- Player-facing, present-tense bullet copy
- Sync with src/domain/device/changelog.ts via npm run release:sync
- Never hand-edit changelog.ts (generated from CHANGELOG.md)
- path: .changeset/**
instructions: |
Review changesets for:
- Player-visible impact described accurately
- Wording matches eventual CHANGELOG.md bullets
- path: '**/*.test.{ts,tsx}'
instructions: |
Review tests for:
- Behavior-focused assertions on changed code paths
- Edge cases for new logic
- Prefer vitest related scope over full suite locally
- path: .github/workflows/**
instructions: |
Review CI workflows for:
- PR smoke e2e vs push full e2e conditions
- Geometry path filter triggering test:perf
- Node 24 and emulator cache keys
# Source: defaults
abort_on_close: true
# Source: defaults
disable_cache: false
slop_detection:
# Source: defaults
enabled: true
auto_review:
# Source: defaults
enabled: true
# Source: defaults
description_keyword: ''
# Source: defaults
auto_incremental_review: true
# Source: defaults
auto_pause_after_reviewed_commits: 5
# Source: defaults
ignore_title_keywords: []
# Source: defaults
labels: []
# Source: defaults
drafts: false
# Source: defaults
base_branches: []
# Source: defaults
ignore_usernames: []
finishing_touches:
docstrings:
# Source: defaults
enabled: true
unit_tests:
# Source: defaults
enabled: true
simplify:
# Source: defaults
enabled: false
autofix:
# Source: defaults
enabled: true
# Source: defaults
custom: []
pre_merge_checks:
# Source: defaults
override_requested_reviewers_only: false
docstrings:
# Source: Repository YAML (base)
mode: 'off'
# Source: defaults
threshold: 80
title:
# Source: Repository YAML (base)
mode: 'off'
# Source: defaults
requirements: ''
description:
# Source: Repository YAML (base)
mode: 'off'
issue_assessment:
# Source: Repository YAML (base)
mode: 'off'
# Source: defaults
custom_checks: []
# Source: defaults
post_merge_actions: []
tools:
ast-grep:
# Source: defaults
rule_dirs: []
# Source: defaults
util_dirs: []
# Source: defaults
essential_rules: true
# Source: defaults
packages: []
shellcheck:
# Source: defaults
enabled: true
ruff:
# Source: defaults
enabled: true
markdownlint:
# Source: defaults
enabled: true
github-checks:
# Source: defaults
enabled: true
# Source: defaults
timeout_ms: 90000
languagetool:
# Source: defaults
enabled: true
# Source: defaults
enabled_rules: []
# Source: defaults
disabled_rules: []
# Source: defaults
enabled_categories: []
# Source: defaults
disabled_categories: []
# Source: defaults
enabled_only: false
# Source: defaults
level: default
biome:
# Source: defaults
enabled: true
hadolint:
# Source: defaults
enabled: true
swiftlint:
# Source: defaults
enabled: true
phpstan:
# Source: defaults
enabled: true
# Source: defaults
level: default
phpmd:
# Source: defaults
enabled: true
phpcs:
# Source: defaults
enabled: true
golangci-lint:
# Source: defaults
enabled: true
yamllint:
# Source: defaults
enabled: true
gitleaks:
# Source: defaults
enabled: true
trufflehog:
# Source: defaults
enabled: true
checkov:
# Source: defaults
enabled: true
tflint:
# Source: defaults
enabled: true
detekt:
# Source: defaults
enabled: true
eslint:
# Source: defaults
enabled: true
e18e:
# Source: defaults
enabled: true
flake8:
# Source: defaults
enabled: true
fbinfer:
# Source: defaults
enabled: true
# Source: defaults
enable_java: false
fortitudeLint:
# Source: defaults
enabled: true
rubocop:
# Source: defaults
enabled: true
buf:
# Source: defaults
enabled: true
regal:
# Source: defaults
enabled: true
actionlint:
# Source: defaults
enabled: true
zizmor:
# Source: defaults
enabled: true
pmd:
# Source: defaults
enabled: true
clang:
# Source: defaults
enabled: true
cppcheck:
# Source: defaults
enabled: true
opengrep:
# Source: defaults
enabled: true
semgrep:
# Source: defaults
enabled: true
circleci:
# Source: defaults
enabled: true
clippy:
# Source: defaults
enabled: true
sqlfluff:
# Source: defaults
enabled: true
squawk:
# Source: defaults
enabled: true
trivy:
# Source: defaults
enabled: true
prismaLint:
# Source: defaults
enabled: true
pylint:
# Source: defaults
enabled: true
oxc:
# Source: defaults
enabled: true
shopifyThemeCheck:
# Source: defaults
enabled: true
luacheck:
# Source: defaults
enabled: true
brakeman:
# Source: defaults
enabled: true
dotenvLint:
# Source: defaults
enabled: true
htmlhint:
# Source: defaults
enabled: true
stylelint:
# Source: defaults
enabled: true
checkmake:
# Source: defaults
enabled: true
osvScanner:
# Source: defaults
enabled: true
oasdiff:
# Source: defaults
enabled: true
reactDoctor:
# Source: defaults
enabled: true
presidio:
# Source: defaults
enabled: true
blinter:
# Source: defaults
enabled: true
smartyLint:
# Source: defaults
enabled: true
emberTemplateLint:
# Source: defaults
enabled: true
skillspector:
# Source: defaults
enabled: true
psscriptanalyzer:
# Source: defaults
enabled: true
chat:
# Source: defaults
art: true
# Source: defaults
allow_non_org_members: true
# Source: Repository YAML (base)
auto_reply: true
integrations:
jira:
# Source: defaults
usage: auto
linear:
# Source: defaults
usage: auto
knowledge_base:
# Source: Repository YAML (base)
opt_out: false
web_search:
# Source: defaults
enabled: true
code_guidelines:
# Source: defaults
enabled: true
# Source: defaults
filePatterns: []
learnings:
# Source: Repository YAML (base)
scope: auto
# Source: defaults
approval_delay: 0
issues:
# Source: defaults
scope: auto
jira:
# Source: defaults
usage: auto
# Source: defaults
project_keys: []
linear:
# Source: defaults
usage: auto
# Source: defaults
team_keys: []
pull_requests:
# Source: defaults
scope: auto
mcp:
# Source: defaults
usage: auto
# Source: defaults
disabled_servers: []
# Source: defaults
automatic_repository_linking: false
# Source: defaults
linked_repositories: []
code_generation:
docstrings:
# Source: defaults
path_instructions: []
unit_tests:
# Source: defaults
path_instructions: []
issue_enrichment:
auto_enrich:
# Source: defaults
enabled: false
planning:
# Source: defaults
enabled: true
auto_planning:
# Source: defaults
enabled: true
# Source: defaults
labels: []
labeling:
# Source: defaults
labeling_instructions: []
# Source: defaults
auto_apply_labels: false
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe CodeRabbit configuration retains the assertive review profile and request-change workflow while explicitly disabling docstring, title, description, and issue assessment pre-merge checks. ChangesReview workflow configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request_changes_workflow: trueso CodeRabbit submitsAPPROVEDorCHANGES_REQUESTEDreviews (not comment-only)pre_merge_checksthat add status noise without review value (title/commit conventions covered by hooks)Pairs with GitHub
mainbranch rules requiring CodeRabbit status + approving review + resolved review threads.Test plan
@coderabbitai configurationon this PR and confirmrequest_changes_workflow: trueAPPROVEDwhen threads are clear (orCHANGES_REQUESTEDwhen not)Summary by CodeRabbit