fix(deploy): route sentry tunnel through worker before static assets#48
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
WalkthroughThe Worker is configured to handle Sentry tunnel requests before static assets. The CSP allows an additional script hash, and the 0.5.12 changelogs document the Sentry routing fix. ChangesSentry routing and release updates
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/sentry-tunneltorun_worker_firstso POST requests hit the Worker handler (fixes 405 from the static asset layer).Context
Production
POST /api/sentry-tunnelreturned 405 because only/assets/*ran the Worker first; the SPA asset handler rejected POST.Test plan
curl -X POST https://jetlag.gelbhart.dev/api/sentry-tunnelreturns 400 (invalid envelope), not 405/premiumconsole: no CSP inline-script violation for the new hash; Sentry uses tunnel successfullySummary by CodeRabbit
Bug Fixes
POSTrequests are now routed to the Worker correctly instead of being treated as static assets.Documentation