Redis Token Revocation Store#1
Open
Hockenba wants to merge 3 commits into
Open
Conversation
acolomba
reviewed
Jun 29, 2026
acolomba
left a comment
acolomba
left a comment
There was a problem hiding this comment.
just some minor comments. spent 30 mins on this and lgtm
| return nil | ||
| end | ||
|
|
||
| local redis_cfg = configuration.redis or configuration |
There was a problem hiding this comment.
i'm not sure why we're doing configuration.redis or configuration
| local REDIS | ||
|
|
||
| load_revocation = function(configuration) | ||
| if not configuration then |
There was a problem hiding this comment.
if not configuration or configuration.storage also works
| end | ||
|
|
||
|
|
||
| local load_revocation do |
There was a problem hiding this comment.
just load_redis i think, since this code doesn't know about how redis is used?
Collaborator
Author
There was a problem hiding this comment.
It actually does know how redis is used, so we can keep this.
|
|
||
|
|
||
| local load_revocation do | ||
| local REDIS |
There was a problem hiding this comment.
is uppercase a convention in this library for static local singletons?
Collaborator
Author
There was a problem hiding this comment.
It is. There are some examples in load_storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a token revocation store for stateless sessions. The ADR explaining the functionality can be found here: https://geico.atlassian.net/wiki/spaces/PLAID/pages/1078296854/APISIX+Stateless+Token+Revocation.