refactor(dynamo-editor): migrate to shared ResultPanel - #497
Merged
Conversation
Replace the legacy DynamoDB result panel with the shared ResultPanel for both the UI editor (offset pagination) and PartiQL editor (cursor mode): - ui-editor: shared panel with offset-mode pagination mapping pageCount×pageSize -> total, preserving page navigation - sql-editor: shared panel cursor mode, @NEXT-PAGE replaces data (executePartiqlStatement gains mode:'append'|'replace') - #cell slot injects edit/delete action buttons (same pattern as the Mongo migration in #495) - delete-confirm-modal lifted to both editors - new utils/dynamo-result.ts: flattenDynamoColumns (unrolls Primary Key group), buildDynamoKeys, formatDynamoCell — shared by both editors Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
…result data - Delete result-panel.vue (517 lines) — superseded by the shared ResultPanel (commit c8c0907). Its delete-confirm-modal lives on. - dbDataStore: persist only the query form (dynamoData.uiQueryForm), not queryData/partiqlData — result panels must start empty on each visit; previously stale rows from a prior session were resurrected even when the user never queried this session. - Remove orphaned i18n keys (noData, partiql.itemsReturned, partiql.loadMore) no longer referenced after the migration. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #497 +/- ##
=======================================
Coverage 60.28% 60.28%
=======================================
Files 122 122
Lines 18962 18962
Branches 885 885
=======================================
Hits 11431 11431
Misses 7268 7268
Partials 263 263
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the MongoDB-style legacy DynamoDB result panel (
dynamo-editor/components/result-panel.vue, 517 lines) with the shared ResultPanel (@/components/result) — the same component used by the Mongo editor (#495) and ES docs browser.Net effect: −526 / +248.
Commits
refactor(dynamo-editor): migrate to shared ResultPanelui-editor.vue: shared panel, offset-mode pagination (pageCount×pageSize→total),@update:page/@update:page-sizepreservedsql-editor.vue: shared panel, cursor mode —@next-pagereplaces data (executePartiqlStatementgainsmode: 'append' | 'replace', default append)#cellslot injects edit/delete action buttons (same pattern as Mongo migration refactor(mongo-editor): migrate to shared ResultPanel #495)delete-confirm-modallifted into both editorsutils/dynamo-result.ts:flattenDynamoColumns(unrolls Primary Key group columns),buildDynamoKeys,formatDynamoCellrefactor(dynamo-editor): delete legacy result-panel, stop persisting result dataresult-panel.vue(517 lines)dbDataStore: persist only the query form (pick: ['dynamoData.uiQueryForm']) — result panels start empty each visit (previously stale rows were resurrected from localStorage)Behavior notes
deleteItemstore action still updates both cachesVerification
vue-tsc --noEmit✓vite build✓