Skip to content

Fix port-reservation race in libtest::Server::start() #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esabol merged 2 commits into from
Jul 17, 2026
Merged

Fix port-reservation race in libtest::Server::start() #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1973c2e
Fix port-reservation race in libtest::Server::start()
p-alik Jul 14, 2026
ae8b4bc
Guarantee port reservation release on all Server::start() exit paths
p-alik Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion libtest/port.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,11 @@ in_port_t get_free_port()
}

all_socket_fd.last_port= ret_port;
release_port(ret_port);

// Deliberately leave the reservation socket bound (not released) so the
// port stays unavailable to other processes' get_free_port() calls until
// the caller explicitly release_port()s it, e.g. once its server is
// confirmed listening. See libtest::Server::start().

return ret_port;
}
Expand Down
9 changes: 8 additions & 1 deletion libtest/server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,14 @@ bool Server::start()
hostname(), port(), "Could not build command()");
}

libtest::release_port(_port);
// Hold the port reservation (acquired via get_free_port()) until start()
// returns by any path -- success, ping timeout, or exception -- so no
// other concurrently-running test process's get_free_port() can grab
// _port while this server is still starting up.
struct PortReservation {
in_port_t port;
~PortReservation() { libtest::release_port(port); }
} port_reservation{_port};

Application::error_t ret;
if (Application::SUCCESS != (ret= _app.run()))
Expand Down
Loading