Skip to content

Fix data race in round_robin --job-retries test #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esabol merged 1 commit into from
Jul 13, 2026
Merged

Fix data race in round_robin --job-retries test #470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/round_robin.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,13 @@ static test_return_t _job_retry_TEST(Context *context, Limit& limit)
NULL, 0, // workload
NULL, // result size
&rc));

// Join the background worker thread before inspecting limit's counters:
// job_retry_WORKER (running on that thread) writes limit->_count with no
// synchronization, so reading it here without a join first is a data race
// (and can observe a stale/torn value if the worker is still mid-retry).
handle->shutdown();

ASSERT_EQ(uint32_t(limit.expected()), uint32_t(limit.count()));
ASSERT_EQ(limit.response(), rc);

Expand Down
Loading