feat(fdtd): loft angled sidewalls - #241
Merged
Merged
Conversation
vvahidd
requested review from
cdaunt,
flaport,
joamatab and
nikosavola
as code owners
August 25, 2026 05:00
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Represent topology-stable PDK sidewall angles as continuous ruled OCC solids while preserving fixed guided-port planes. Geometry with incompatible component, hole, or edge correspondence safely retains the bounded-error stepped path.
The ruled loft was selected after benchmarking explicit faceting and 4/8-slice controls. For the GPDK mmi1x2 at 50 nm local sizing, production generates a 2.323 MB / 50,464-element mesh with an exact 10-degree boundary; ZapFDTD dry-run and the FDTD notebook pass.
Validated with 30 FDTD tests, targeted type checking, pre-commit hooks, notebook execution, and ZapFDTD dry-run.