Fix port impedance and complex voltage reconstruction in 2N AC sweep solver - #45
Merged
Conversation
…in 2N solver Two bugs in _setup_ac_sweep_2n: - Port termination impedance was missing from imaginary diagonal block - Complex port voltage reconstruction silently dropped the imaginary part Tests tightened to full complex comparison; added lossy waveguide test. Closes #43
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
cdaunt
marked this pull request as ready for review
July 31, 2026 13:06
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_setup_ac_sweep_2n(only real diagonal was set)holomorphic=FalseAC sweepsDetails
[port, port]and imaginary block[port+N, port+N]V[port_nodes, :]+1j * V[port_nodes + N, :]jnp.abs) to full complex comparisonFixes #43