Development - #42
Merged
Merged
Conversation
Add `params_map` parameter to `compile_netlist()` and `compile_circuit()` to rename netlist setting keys to model field names before compilation. This allows users to decouple netlist setting names from the underlying model's expected field names, resolving issue #40.
feat(compiler): add params_map for setting-to-field name mapping
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015hjPHfevSPUnELhHaMCpWb
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Add compile_osdi as a depends-on dependency of nbrun and pytest_all tasks so that Verilog-A OSDI binaries are compiled via openvaf-r before notebooks execute or long tests run. This prevents FileNotFoundError when gitignored .osdi binaries are missing from a fresh checkout. The compile_osdi task itself remains decoupled from build/build-conda to preserve LGPL separation boundaries between source and packaging. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge changes ahead of release