feat(settings): runtime toggle for prefer-window-name#167
Open
0x79H wants to merge 1 commit into
Open
Conversation
- GET/PUT /api/settings/prefer-window-name persisted in app_settings; the env var stays the initial default, a stored value wins - pass the value to the session refresh worker per request since its config snapshot is frozen at spawn - rebroadcast server-config on change so connected clients converge without a reload, and schedule a refresh for prompt sidebar updates - settings modal: Prefer Window Names switch next to Mouse Mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164.
What
AGENTBOARD_PREFER_WINDOW_NAMEcurrently requires a server restart and isn't discoverable. This wires it into the existing runtime-settings pattern (liketmux-mouse-mode):GET/PUT /api/settings/prefer-window-name, persisted underprefer_window_nameinapp_settings; the env var remains the initial default, a stored value wins once toggled (same contract ashistory-max-age-hours). Persist failure rolls back the runtime value and returns 500 (same contract astmux-mouse-mode).RefreshWorkerRequest.preferWindowName) since its ownconfigsnapshot is frozen at spawn time.PUTrebroadcastsserver-configso already-connected clients (mobile tab labels readpreferWindowNamefrom the session store) converge without a reload, and schedules a refresh so sidebar names update within about a second.Verification
HOSTNAME=127.0.0.1): full suite green, coverage mode andvite buildpass on this branch in isolation.Feel free to rework or take this over entirely — happy either way.