fix(terminal): paste into the session the pty client is attached to#166
Open
0x79H wants to merge 1 commit into
Open
fix(terminal): paste into the session the pty client is attached to#1660x79H wants to merge 1 commit into
0x79H wants to merge 1 commit into
Conversation
- paste() targeted the grouped ws session unconditionally; after switching into an externally-discovered session the buffer landed in the ws session's bootstrap window and the paste was lost - track lastEffectiveSession from the verified switch identity and paste into that session's active pane, falling back to the ws session before the first switch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #162.
What
paste()targeted the grouped ws session unconditionally; after switching into an externally-discovered session the buffer landed in the ws session's own bootstrap window and the paste was silently lost (verified against master's exact command sequence — see the issue). The proxy now recordslastEffectiveSessionfrom the verified switch identity and pastes into that session's active pane, falling back to the ws session before the first switch (reset on dispose). Session-level targeting also keeps following manualprefix+nwindow changes made inside the terminal.Verification
HOSTNAME=127.0.0.1): full suite including the real-tmux layer — green; coverage mode and build pass.Tiny fix — feel free to fold it into anything else or rework as you prefer.