fix(onboarding): answer the promise of the clicked CTA on resumed sessions - #57
Merged
Conversation
…sions The welcome copy read only the session's stored entry source, which resume keeps from the ORIGINAL entry - so a user clicking 'Open in full editor' into a resumed (or pre-attribution) session saw the default 'Grow 10x' hero with zero connection to the button they pressed. The current navigation's ?from= now drives the welcome copy (arrivalSource through the context) while event attribution keeps the stored source unchanged.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking 'Open in full editor' opened the onboarding on 'Grow 10x on LinkedIn' - no connection to the clicked button. Cause: welcome copy read
answers.entrySource, and a resumed session keeps the source it STARTED with (by design, for attribution) - so the fresh?from=tool_headerwas discarded (onboarding-controller.tsxeven drops the parsed param entirely whenresumeAnswersexists). Any session started before entry attribution shipped (07-31) resolves todirectand always gets the default hero.Fix
Split the two concerns:
arrivalSource(this navigation's?from=, threaded controller -> modal -> context) now drives the welcome copy with precedence current-click -> stored source -> experiment default hero. Event attribution (entry_sourceon events and the persisted session) is untouched - the documented resume rule still holds for analytics.Dictionary updated with the attribution-vs-copy distinction.