Build and publish a helix-builder image - #579
Merged
Merged
Conversation
Mirrors the existing relay, data-api and simulator jobs against the builder.Dockerfile that was already in the tree. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit 670c45a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: none (CI only)
What this PR does
Adds a
build-builderjob to.github/workflows/build.yml, publishingghcr.io/<owner>/helix-builder.builder.Dockerfilehas been in the tree since#456 but was wired to nothing, so the only image you could not pull was the one
for
crates/builder.Cherry-picked from #578 so it does not wait behind the 11-PR Gloas stack — the
job is independent of that work and useful now.
The job is byte-identical to
build-simulatorapart from the component name,including the
pull_requestbranch inSet IMAGE_NAME, which is unreachablegiven the workflow's triggers but is what the other three jobs carry. Diverging
from them seemed worse than carrying the dead branch.
What this PR deliberately does not do
collapsing them would rewrite the three existing jobs. Worth doing separately.
admin.Dockerfilestill has no job. Left alone; worth a follow-up if thatimage is meant to be published.
builder.Dockerfile. Document Gloas support, add a testnet runbook, and publish a helix-builder image #578 adds8552to itsEXPOSElinefor the simulation role's SSZ port; that belongs with the stack, and
EXPOSEis documentation rather than enforcement, so the image builds the same either
way.
Tests
Not exercised by CI on this PR: the workflow fires only on pushes to
main/developand onworkflow_dispatch. Dispatch it against this branch tosee it pass before merging.
Checked instead by building the Dockerfile's
chefandplannerstages, whichis where a manifest change would break it, and by diffing the new job against
build-simulatorstructurally. I did not run the fullcook/build — that is anethrex plus rocksdb compile, and CI is the right place for it.
Reviewer checklist
lint,unit-test) is green