Reject blocks that interact with a blacklisted address - #535
Open
0w3n-d wants to merge 1 commit into
Open
Conversation
Interaction means effect: a state change, or a transaction addressed to the account. The coinbase and the proposer fee recipient are checked directly, since neither has to change state. Reading an account is not interaction. The reth simulator rejects such a block, so the two disagree; see the test that records it. Step 6 of #527. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #527 (step 6 of 10)
Base branch:
od/builder-sim-payment-step5(#534, step 5). Retarget as the stackmerges.
What this PR does
Rejects a block that interacts with a listed address, where interaction means
effect:
proposer_fee_recipient, checked directlybecause neither has to change state — a block with no priority fees leaves
the coinbase untouched, and an unpaid recipient stays absent from the state;
to, since a call that changes nothing leaves no accountupdate behind;
account_updates: senders, created accounts,value recipients and storage writes.
validateandvalidate_mergedtakeapply_blacklist, so a non-filteringproposer's block skips the check.
Rule 3 makes reth's
DatabaseLoggerunnecessary. The account updatesexecutealready returns are the set of accounts execution changed, so no read-tracking
database wrapper is needed at all.
Deliberate divergence from the reth simulator
reth rejects a block that merely reads a listed account during execution: it
scans every account touched in the revm cache. That over-approximates — an
unrelated read trips it. This simulator rejects only interaction by effect.
The two therefore disagree on one class of block, and a builder's verdict depends
on which simulator drew the request. The direction is the safer one (fewer false
positives, not more false negatives), and
an_account_that_is_only_read_is_not_blacklistedrecords it. If they should be aligned, the fix is to move this rule into
helix-commonand switch reth to it, the same shape as #533.What this PR deliberately does not do
No blacklist refresh task. The list is an injected
Arc<DashSet<Address>>;polling
blacklist_endpointarrives with the servers in step 9.Tests
Written first and signed off before implementation. 9 new, 41 in the file:
value, so it never appears as any transaction's
toand only the state changereveals it. This is what rule 3 buys.
nonce.
(
PUSH0 CALLDATALOAD BALANCE POP STOP) in the genesis. The test asserts theprobe's receipt succeeded, so it cannot pass by the call having failed.
apply_blacklist = falseskips thecheck.
just fmt-check,just testandcargo clippy --all-features --no-deps -- -D warningsare clean. 75 tests pass in
helix-builder, up from 66.Reviewer checklist
lint,unit-test) is green