test(network): reduce backpressure test timing sensitivity - #150
Merged
Conversation
The multi-client backpressure test queued an 8 MiB payload for a receiver that initially pauses, then allowed five seconds for the queued payload and marker to arrive. Observed runs came close to that deadline, making the test sensitive to timing variation. Reduce the payload to 2 MiB to provide more headroom. It remains much larger than the requested 1 KiB socket buffer, while the receiver delay continues to create backpressure. Avoid the unconditional sleep after poll activity, reducing unnecessary delay while the connection is making progress. Also document that infrequent calls to poll_with can slow queued-write progress under backpressure. Assisted-by: Claude:claude-fable-5 Assisted-by: Codex:gpt-5.6-sol
ltitanb
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky test.
The multi-client backpressure test queued an 8 MiB payload for a receiver that initially pauses, then allowed five seconds for the queued payload and marker to arrive. Observed runs came close to that deadline, making the test sensitive to timing variation.
Reduce the payload to 2 MiB to provide more headroom. It remains much larger than the requested 1 KiB socket buffer, while the receiver delay continues to create backpressure.
Avoid the unconditional sleep after poll activity, reducing unnecessary delay while the connection is making progress. Also document that infrequent calls to poll_with can slow queued-write progress under backpressure.