Supporting OpenRouter Embedding Models#52
Open
oliverkiranbrown wants to merge 6 commits into
Open
Conversation
…ion - must ensure consistency in embedding model
…en vec db creation and retrieval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49
Changes
LLM_Client.get_embeddings_model()now branches based onprovider["type"]. Ollama providers keep usingOllamaEmbeddings, but openai-type providers (including OpenRouter) useOpenAIEmbeddingswith the required base URL / API key.config.pyhave their ownembeddings_model, as the avalible models vary by provider.embeddings_provider_priority. Can change this around as desired.vector_database_manager.pyhad a hardcodedOllamaEmbeddings. Now removed. The embedding model is taken directly fromLLM_ClientI haven't had time to test this myself. Can take a look later this week when I get a chance.