[pull] master from ray-project:master#1077
Merged
Merged
Conversation
…benchmark (#64125) ## Description The video object detection benchmark previously ran with the default Ray Data settings, which don't guard against the OOMs we want this benchmark to be resilient to. This enables the memory-safety best practices we recommend to users so the benchmark exercises (and validates) them. Specifically, it: - Sets `isolate_read_workers = True` so other operators' tasks don't get co-scheduled with read workers. - Sets `default_map_logical_memory_enabled = True` so the system reserves logical memory for map UDFs by default. - Sets `memory=3_529_273_344` (~3.5 GB) on the high-memory `ExtractImageFeatures` UDF. Ray Data can't prevent OOMs unless `memory` is specified for high-memory UDFs; this value is the max USS observed in previous nightly runs. These are opt-in settings (not enabled by default), so they only affect this benchmark. ## Related issues ## Additional information Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )