[pull] master from ray-project:master#1067
Merged
Merged
Conversation
Co-authored-by: sampan <sampan@anyscale.com> Signed-off-by: sampan <sampan@anyscale.com> Signed-off-by: Sampan S Nayak <sampansnayak2@gmail.com>
Metrics from the TPU device plugin have some quirks that cause issues for the dashboard: 1. Tensor core and memory bandwidth utilization are indexed by host (i.e. zero to N-1 where N is chips per host), while the other metrics are "runtime metrics" and indexed across the complete running slice. They will sometimes but almost never line up precisely. 2. V7X clusters I've tested against only have the host metrics, which means the dashboard must gracefully degrade to show memory utilization without absolute byte info. To work around this, the reporter agent can re-index the non-host metrics to share the same indices as the host metrics by assigning them in-order. Additionally, I've cleaned the TPU path for the accelerator rows to gracefully degrade on the missing metrics paths. ## Related issues - Addresses bugs in #63774 - To unblock chip-to-pid mapping in #63976 ## Additional information Example dashboard with correct chip ids and absolute memory: <img width="1473" height="1057" alt="image" src="https://github.com/user-attachments/assets/06b8d492-4db8-4247-99ea-72daef66716b" /> Example dashboard missing absolute GiB memory (some 0.0 rows show different visual bars because it was animating while screenshotting): <img width="1378" height="1120" alt="image" src="https://github.com/user-attachments/assets/f807bcbf-0c7a-4fa7-a8e3-94c25ad16e0b" /> --------- Signed-off-by: Spencer Peterson <spencerjp@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )