Allow smart-quotes-insert-{single,double} to work with electric-pair-mode#8
Open
rrthomas wants to merge 7 commits into
Open
Allow smart-quotes-insert-{single,double} to work with electric-pair-mode#8rrthomas wants to merge 7 commits into
rrthomas wants to merge 7 commits into
Conversation
Contributor
Author
|
This fixes issue #6. |
Contributor
Author
|
I added removal of turn-{on,off}-smart-quotes: minor modes work conveniently without this (in particular, if called from Lisp with no argument, the mode is unconditionally turned on). |
…mode Common up the two functions, then make the resulting smart-quotes--insert call insert-char when it is swapping an existing quote, and set last-command-event then call self-insert-command otherwise. In the latter case (inserting a quote), post-self-insert-hook is run, and the quote’s pair can be added by electric-pair-mode.
Minor modes support this naturally now. Update the docstring of smart-quotes-mode to reflect this.
Contributor
Author
|
Ping? I just found and fixed a minor bug in this PR, namely that it needs to |
Contributor
Author
|
Ping again? I'd be happy to take this mode over, as I use it all the time. |
Also modernize the installation instructions, and update the link to the GPL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Common up the two functions, then make the resulting
smart-quotes--insert call insert-char when it is swapping an existing
quote, and set last-command-event then call self-insert-command
otherwise. In the latter case (inserting a quote), post-self-insert-hook
is run, and the quote’s pair can be added by electric-pair-mode.