Feature/synchronize or reveal - #2
Merged
Merged
Conversation
meson only added 'c23' as a recognised c_std value in 1.4, but the project
declares meson_version >=1.3.0. On meson 1.3.x configuration fails outright:
ERROR: Unknown C std ['c23']. Possible values are [... 'c2x' ...]
Newer meson still accepts 'c2x' and it selects the same standard, so 'c2x' is
the spelling that works across the supported meson range.
sync_module.c calls mgp_list_append_move, mgp_map_insert_move and mgp_unordered_map_make_empty. Memgraph 3.1.1 ships none of them, so the module fails to compile against a stock 3.1 install. Add guarded shims implementing the three on top of the copying variants, and detect the situation in meson via cc.has_header_symbol rather than requiring -DSYNC_KGRAPH_MGP_COMPAT to be passed by hand. Against newer headers the shims compile out entirely and nothing changes. Note for review: mgp_list_append and mgp_map_insert copy the value, so the shims destroy the source on success to preserve the move-semantics contract the call sites rely on (they destroy the value themselves on failure). That mirrors what the real *_move functions do, but it is an assumption about the intended contract rather than something the headers state, so it is worth confirming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #1: new API for homing/disambiguating sequences as well as a general update to the previous API