-
-
Notifications
You must be signed in to change notification settings - Fork 406
feat(loader): support constructed values and nested calls #3067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
GuoLei1990
merged 8 commits into
galacean:dev/2.0
from
luzhuang:feat/runtime-type-constructor-args
Jul 16, 2026
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ceba5a3
feat(loader): support constructed values and nested calls
luzhuang 84b6141
fix(loader): decode infinite burst cycles
luzhuang 1307f43
fix(asset): make virtual sub-asset loading reliable
luzhuang be65ff7
refactor(loader): make special number decoding generic
luzhuang 37a3252
fix(asset): reject missing sub-asset paths
luzhuang b8ce4df
chore: remove development notes
luzhuang 7f2bcba
fix(asset): allow sub-asset retries after failure
luzhuang aa62327
refactor(asset): remove legacy virtual resource API
luzhuang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🔴 Critical | ⚡ Quick win
Block prototype and constructor traversal before invoking nested calls.
Loader-controlled paths can traverse function properties and reach
Function, for exampletarget: ["nested", "setValue"]withmethod: "constructor". Combined withcall.result, this permits constructing and invoking arbitrary JavaScript.Reject
constructor,prototype, and__proto__in both target segments and method names.Proposed guard
🤖 Prompt for AI Agents