Skip to content

benchmark: add release parity harness - #5

Merged
gaelic-ghost merged 1 commit into
mainfrom
benchmark/v0.8.0
Jul 1, 2026
Merged

benchmark: add release parity harness#5
gaelic-ghost merged 1 commit into
mainfrom
benchmark/v0.8.0

Conversation

@gaelic-ghost

Copy link
Copy Markdown
Owner

Summary

  • add a SwiftPM MaxVolBenchmark executable with deterministic fixture resources
  • add uv-backed maxvolpy comparison and JSONL parity scripts
  • document benchmark, parity, allocation-profiling workflow, and v0.9.0 performance plan

Validation

  • swift build
  • swift test
  • swift build -c release --product MaxVolBenchmark
  • .build/release/MaxVolBenchmark --iterations 2
  • uv run --python 3.11 scripts/compare_maxvolpy.py --iterations 2
  • python3 scripts/check_benchmark_parity.py /private/tmp/maxvol-swift-all.jsonl /private/tmp/maxvol-python-all.jsonl
  • swift test -c release
  • xcrun docc convert Sources/MaxVol/MaxVol.docc ...
  • scripts/repo-maintenance/validate-all.sh

@gaelic-ghost gaelic-ghost added the enhancement New feature or request label Jul 1, 2026
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@gaelic-ghost, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2b8d2409-46b4-4b67-9714-5dfc1d9b56af

📥 Commits

Reviewing files that changed from the base of the PR and between d3cbc2e and e6f6679.

📒 Files selected for processing (15)
  • .gitignore
  • Package.swift
  • README.md
  • ROADMAP.md
  • Sources/MaxVol/MaxVol.docc/BenchmarkingAndParity.md
  • Sources/MaxVol/MaxVol.docc/MaxVol.md
  • Sources/MaxVolBenchmark/Resources/fixtures.json
  • Sources/MaxVolBenchmark/main.swift
  • Tests/MaxVolTests/FloatMaxVolTests.swift
  • Tests/MaxVolTests/NumericalBehaviorTests.swift
  • Tests/MaxVolTests/RectMaxVolTests.swift
  • Tests/MaxVolTests/TestSupport.swift
  • scripts/check_benchmark_parity.py
  • scripts/compare_maxvolpy.py
  • scripts/generate_benchmark_fixtures.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch benchmark/v0.8.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gaelic-ghost
gaelic-ghost merged commit c9f999b into main Jul 1, 2026
2 checks passed
@gaelic-ghost
gaelic-ghost deleted the benchmark/v0.8.0 branch July 1, 2026 06:23

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6f6679046

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

f"Swift={swift['selectedRowCount']} Python={python['selectedRowCount']}"
)

residual_delta = abs(swift["reconstructionResidual"] - python["reconstructionResidual"])

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Check square coefficient magnitude during parity

For square MaxVol records, selected row count is always the matrix column count and reconstruction residual stays near zero for any nonsingular basis, so a regression that stops at the initial LU basis (for example the square-swap-3x2 case with maxIterations: 0) would still pass this checker even though its coefficient magnitude violates the MaxVol tolerance and differs from maxvolpy. Compare maxCoefficientMagnitude for square records (or against the square tolerance) before declaring parity.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant