Implement initial Accelerate-backed MaxVol package - #1
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae3f6c11b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| push_release_branch "$branch_name" | ||
| create_or_update_pr "$branch_name" | ||
| pr_number="$PR_NUMBER" | ||
| wait_for_initial_pr_checks "$pr_number" |
There was a problem hiding this comment.
When release.sh --mode standard --dry-run reaches this path, create_or_update_pr has just set PR_NUMBER="DRY-RUN", but this unguarded call still enters wait_for_initial_pr_checks and polls gh pr checks DRY-RUN until it times out. That makes the dry-run path hang or fail instead of staying side-effect-free, so this call should be skipped or simulated when REPO_MAINTENANCE_DRY_RUN=true.
Useful? React with 👍 / 👎.
| tag_sha="$(git -C "$REPO_ROOT" rev-parse -q --verify "refs/tags/$RELEASE_TAG" 2>/dev/null || true)" | ||
|
|
||
| if [ -n "$tag_sha" ]; then | ||
| [ "$tag_sha" = "$head_sha" ] || die "Tag $RELEASE_TAG already exists and does not point at HEAD." |
There was a problem hiding this comment.
In submodule release reruns after this script has created the annotated tag, git rev-parse --verify refs/tags/$RELEASE_TAG resolves to the tag object, not the commit, so comparing it directly with rev-parse HEAD rejects a valid tag that already points at HEAD. The standard release helper handles this by using git rev-list -n 1; this path needs the same peeling before deciding the tag is wrong.
Useful? React with 👍 / 👎.
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (33)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Add package build and test to the required workflow
Because this is currently the only workflow under .github/workflows and the validate check is the one branch protection is told to require, stopping at scripts/repo-maintenance/validate-all.sh leaves PRs that change Package.swift or Sources/MaxVol without any swift build or swift test coverage; validate-all.sh only dispatches the repo-maintenance scripts under scripts/repo-maintenance/validations. That means compile failures or failing Swift Testing coverage can still merge as long as the maintenance wrapper passes, so the package build/test gate should be added here or to validate-all.sh.
MaxVol/scripts/repo-maintenance/release.sh
Line 449 in d2f26c2
Allow standard dry runs without gh installed
When release.sh --mode standard --dry-run is used for a local side-effect-free rehearsal on a machine without the GitHub CLI, this unconditional ensure_gh_cli call exits before any of the dry-run guards can simulate PR, CI, merge, or release operations. Skip this check during dry runs, or defer it until the first non-dry-run gh operation, so the advertised dry-run path can run in environments that intentionally lack GitHub credentials/tools.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary: Adds dense column-major matrix storage, public result/error/options APIs, a first Accelerate-backed Double square MaxVol implementation, Swift Testing coverage, ROADMAP planning, DocC, and SPI metadata. Verification: swift build; swift test; scripts/repo-maintenance/validate-all.sh; xcrun docc convert with the MaxVol symbol graph.