Upgrade to net10#11
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly modernizes the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully upgrades the project from the legacy .NET Framework to a modern SDK-style project. My review focuses on several important corrections and improvements for the new .csproj file. There is a critical issue with an invalid Target Framework Moniker that will prevent the project from building. I've also included suggestions to align the project with modern .NET best practices, such as using the correct SDK for Windows Forms, cleaning up redundant references, and ensuring assembly metadata is preserved.
| <ProductVersion>9.0.21022</ProductVersion> | ||
| <SchemaVersion>2.0</SchemaVersion> | ||
| <ProjectGuid>{AF33361C-4CFB-44C0-9070-FDB34A87E362}</ProjectGuid> | ||
| <TargetFramework>net10.0-windows</TargetFramework> |
There was a problem hiding this comment.
The Target Framework Moniker (TFM) net10.0-windows is not valid and will cause the build to fail. Please use a valid TFM. For example, if you are targeting .NET 8 (the current Long-Term Support version), the correct TFM would be net8.0-windows.
<TargetFramework>net8.0-windows</TargetFramework>
There was a problem hiding this comment.
That is not true, it is a valid TFM. Check the the docs here https://learn.microsoft.com/en-us/dotnet/standard/frameworks#os-specific-tfms
| @@ -1,22 +1,11 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project ToolsVersion="3.5" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
For Windows Forms applications, it's recommended to use the Microsoft.NET.Sdk.WindowsDesktop SDK. This simplifies the project file by automatically including necessary settings and references for Windows Forms. By making this change, you can also remove the <ImportWindowsDesktopTargets>true</ImportWindowsDesktopTargets> property on line 25, as it becomes redundant.
<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
There was a problem hiding this comment.
Not needed anymore. If you use Microsoft.NET.Sdk.WindowsDesktop the compiler throws a warning:
warning NETSDK1137: It is no longer necessary to use the Microsoft.NET.Sdk.WindowsDesktop SDK. Consider changing the Sdk attribute of the root Project element to 'Microsoft.NET.Sdk'| <Reference Update="System.Core"/> | ||
| <Reference Update="System.Xml.Linq"/> |
There was a problem hiding this comment.
In SDK-style projects, framework assemblies like System.Core and System.Xml.Linq are referenced automatically as part of the target framework. These <Reference Update="..." /> tags are unnecessary and should be removed to keep the project file clean.
There was a problem hiding this comment.
That's correct, I removed them with a new commit.
|
Can you test on some old windows like windows 10 to ensure the compatible is OK? |
|
Sure I checked it. As long as D:\Repos\runapp> dotnet publish -p:PublishSingleFile=true --self-containedHere is a gif for the test on Windows 10.
|
3 participants
We are updating our system where your app is used. I wanted to get rid of the dependency to .Net Framework 3.5 and didn't want to find another launcher alternative.