Fix CLI buy/sell payload types#36
Open
krandder wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for futarchy-ai ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buybudgets andsellamounts as strings to match the live API schemafloatin the CLI entrypointWhy
Issue #35 is only partially resolved on
main:futarchy activityalready exists, butfutarchy buyandfutarchy sellstill post numeric JSON values while the live API expects strings.Validation
python3 -m py_compile cli/futarchy_cli/api.py cli/futarchy_cli/main.py core/test_cli_compat.pypytest -q core/test_cli_compat.py core/test_api.pypython3 -m futarchy_cli.main buy --helppython3 -m futarchy_cli.main sell --help