Cognizine makes hostile mobs solo antagonists

[pirakaplant]

About the PR

When under the effects of cognizine, a mob that would normally automatically attack crew will become a solo antagonist when controlled by a ghost. The ghost rules popup will also change to reflect this.

Why / Balance

The admin team doesn't like how cognizine is used to "tame" hostile space mobs, and expects those mobs to remain hostile to crew regardless of whether they are sapient or not. This PR makes it clear to players that they should play sapient hostile mobs as hostile.

Technical details

This code amends the MakeSentientEntityEffectSystem to add two checks:

1. If the mob does not belong to any factions, the code returns, defaulting to a crew-aligned ghost role.
2. If the mob does belong to one or more factions, the code runs a foreach loop to check if any of those factions would attack crew (which is anyone belonging to the NanoTrasen faction). If one of of them does, it updates the ghost rules to a set that mentions the role's Solo Antagonist status, adds the MindRoleGhostRoleSoloAntagonist mind role, and returns.

Test plan

1. Cognizine a non-hostile mob, such as the dev environment's "real mouse", ghost, and take the ghost role. You should observe no changes.
2. Cognizine mobs from two different hostile factions (such as a space carp, which belongs to the Dragon faction, and a space adder, which belongs to the Xeno faction). Both of them should have a modified set of ghost rules (see Media) and make you a solo antagonist when you take the role.

Media

Requirements

• I have read and am following the Macrocosm Pull Request Conventions.
• I have tested this pull request and written instructions on how to test it
• I have added media to this PR or it does not require an in-game showcase.
• If I am porting something, I have done my best to respect the appropriate licenses associated with the presented changes.

License

MIT

Breaking changes

N/A.

Changelog

🆑

• tweak: Hostile mobs become solo antagonists upon becoming sapient.

[jhardtmadsen-blip]

THANK YOU THANK YOU THANK YOU

[PoquitoDondito]

Admin team here. I like this (and we asked for this) because what I've noticed is that players like to befriend flora/fauna (see the first couple weeks of mini dragon) when they shouldn't. This isn't necessarily the crew's fault, because they're just reacting to what is given to them. Instead, the expectation should be set on the things that are normally antags to, y'know, be antagonists. We don't want a salvage ship being a friendship is magic ship, we want them to have corpses and a rotting salvager.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[pirakaplant]

ALREADY??!!