Port department handhelds, emergency channel and encryption key resprites - #262
Open
mycobiota wants to merge 9 commits into
Open
Port department handhelds, emergency channel and encryption key resprites#262mycobiota wants to merge 9 commits into
mycobiota wants to merge 9 commits into
Conversation
Co-authored-by: funkystationbot <funky@funkystation.org>
* Resprited Encryption Keys * chore: Automatically update REUSE headers --------- Co-authored-by: funkystationbot <funky@funkystation.org>
github-actions
Bot
added
Status: Needs Review
size/M
Changes: No C#
Changes: Sprites
Status: Untriaged
and removed
size/M
labels
Author
|
if you saw the other one, no you didn't |
Contributor
|
RSI Diff Bot; head commit f0bb5cb merging into e62f294 Resources/Textures/_Funkystation/Objects/Devices/encryption_keys.rsi
Resources/Textures/_Funkystation/Objects/Devices/radio.rsi
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Ports funky-station/funky-station#1263 and funky-station/funky-station#1440
Encryption keys have been resprited (by Catazeus), and handheld radios have been touched up and expanded on (by willowzeta and vectorassembly).
Also adds the emergency radio channel, reserved for emergency handhelds, the warden, and paramedics (by willowzeta).
The new departmental and emergency radios are now part of various inventories, such as the lockers of department heads.
Also renames the supply / cargo encryption key to "Logistics" in line with funky-station/docs#96
Why / Balance
See funky-station/funky-station#1440: "Allows corporate hierarchy to be properly maintained in the event of a telecommunications outage." The emergency channel leans more into the "emergency dispatcher" side of warden and benefits paramedics as well.
the encryption keys look good also
Technical details
yaml
Test plan
Try out the different handheld radios and make sure they broadcast and receive on their channels fine
Make sure dispatch headset appears in warden's locker and paramedic headset appears in paramedic's locker
Make sure secoffs spawn with a security radio in their belt
Make sure department head lockers contain a command and department radio
Make sure HOP's PTech vendor contains various department radios and emergency radios
Make sure salvage lockers contain supply handheld radios
Make sure emergency closets and emergency toolboxes sometimes contain emergency handhelds
Media
Requirements
License
MIT
Breaking changes
to use different sprites for the encryption keys, point the rsi on the base encryption key proto elsewhere and make sure to revert funky specific sprite layers to whatever is upstream
to prevent the new radios from appearing, remove all RadioHandheld[Channel goes here] protos from the entityTables and such in Resources/Prototypes/Catalog/
remove EncryptionKeyEmergency from anywhere it appears to prevent it from showing up and remove the emergency channel from Resources/Prototypes/_Funkystation/radio_channels.yml
revert ClothingHeadsetParamedic to ClothingHeadsetMedical in the paramedic's gear and ClothingHeadsetWarden to ClothingHeadsetSecurity in the warden's gear to prevent them from spawning with the unique headsets and remove them from their locker fill entityTables to prevent the headsets from appearing in their lockers
Changelog
🆑