Drag drop jobs

[Chapien]

About the PR

This is a merging of a pending upstream PR, which you can find here: space-wizards/space-station-14#41942

Why / Balance

This allows you to drag and drop the priorities of your jobs in a graphical manner. This is meant to lay the ground work for having multiple active characters as we do in Funky, but that feature is not implemented here yet.

Technical details

See space-wizards/space-station-14#41942

Test plan

1. Enter the lobby
2. Create a character with some jobs enabled
3. Drag and drop the jobs, load into a round and see if you got your highest priority job

Media

See space-wizards/space-station-14#41942

Requirements

• I have read and am following the Macrocosm Pull Request Conventions.
• I have tested this pull request and written instructions on how to test it
• I have added media to this PR or it does not require an in-game showcase.
• If I am porting something, I have done my best to respect the appropriate licenses associated with the presented changes.

License

MIT

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[Chapien]

Will look into the failures when I have time.

[Chapien]

I believe build failures are due to differing compiler versions between when this PR was made and our compiler version. I will apply the necessary changes. Weirdly, it works on my machine. I'm going to try and tell github to compile again and see if anything changes, if it fails again I'll make the changes.

[Chapien]

Alternatively, the failures might not actually matter.

[pirakaplant]

This allows you to have multiple active characters, each with different jobs, selected based on where they are positioned on a priority drag-and-drop.

This code does not do that. You can still only have one active character at a time, this just updates that character's individual job settings.

Besides that, the code for the most part looks good to me. The one thing I've noticed when testing is that the customise menu does not update job priorities when things are dragged and dropped, and I feel like it should.

[Chapien]

This allows you to have multiple active characters, each with different jobs, selected based on where they are positioned on a priority drag-and-drop.

This code does not do that. You can still only have one active character at a time, this just updates that character's individual job settings.

Besides that, the code for the most part looks good to me. The one thing I've noticed when testing is that the customise menu does not update job priorities when things are dragged and dropped, and I feel like it should.

Right, I totally forgot that they split the functionality into two different PRs. Annoying. We can implement this as is, wait for the secondary PR to be finished, or I can go in and try to add the functionality (again).

[Chapien]

This allows you to have multiple active characters, each with different jobs, selected based on where they are positioned on a priority drag-and-drop.

This code does not do that. You can still only have one active character at a time, this just updates that character's individual job settings.

Besides that, the code for the most part looks good to me. The one thing I've noticed when testing is that the customise menu does not update job priorities when things are dragged and dropped, and I feel like it should.

Okay, edited the description.