Skip to content

fix(#2856): calibrate ADR convention violation severities in review agent#2857

Merged
rh-hemartin merged 1 commit into
mainfrom
agent/2856-adr-severity-calibration
Jul 3, 2026
Merged

fix(#2856): calibrate ADR convention violation severities in review agent#2857
rh-hemartin merged 1 commit into
mainfrom
agent/2856-adr-severity-calibration

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

The review agent correctly identified ADR immutability violations but rated them at low severity, causing authors to dismiss findings that human reviewers later treated as blocking. Add explicit severity rules to the intent-coherence sub-agent: substantive rewrites of accepted ADR sections are high severity, amendment scope violations are medium, and novel annotation formats remain low. Register the new categories in the orchestrator's dimension mapping so findings route correctly.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com


Closes #2856

Post-script verification

  • Branch is not main/master (agent/2856-adr-severity-calibration)
  • Secret scan passed (gitleaks — 43388d57a168ed0b5caf97463414003677404fa2..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

…gent

The review agent correctly identified ADR immutability violations but
rated them at low severity, causing authors to dismiss findings that
human reviewers later treated as blocking. Add explicit severity rules
to the intent-coherence sub-agent: substantive rewrites of accepted ADR
sections are high severity, amendment scope violations are medium, and
novel annotation formats remain low. Register the new categories in the
orchestrator's dimension mapping so findings route correctly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@fullsend-ai-coder fullsend-ai-coder Bot requested a review from a team as a code owner July 1, 2026 17:12
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Agent PR ready for human review label Jul 1, 2026
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

Site preview

Preview: https://749e3ac3-site.fullsend-ai.workers.dev

Commit: 2dcdb3cf01b503a5fd95f927656315cfbf68693b

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@rh-hemartin rh-hemartin added this pull request to the merge queue Jul 3, 2026
Merged via the queue into main with commit 060bf56 Jul 3, 2026
16 of 21 checks passed
@rh-hemartin rh-hemartin deleted the agent/2856-adr-severity-calibration branch July 3, 2026 09:33
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 3, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 9:35 AM UTC · Completed 9:46 AM UTC
Commit: 2dcdb3c · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

PR #2857 is a bot-authored fix that calibrates ADR convention violation severities in the review agent's intent-coherence sub-agent. It was generated from issue #2856, which was itself filed by the retro agent after analyzing PR #2453 — where the review agent under-rated ADR immutability violations (LOW) that human reviewers treated as blocking (HIGH). The code agent produced a clean single-commit fix adding severity guidance and two new finding categories (adr-immutability-violation at HIGH, adr-amendment-scope at MEDIUM/LOW). The fix was approved by a single human reviewer with no comments and merged after passing all CI checks.

Two notable findings:

  1. Review agent did not run on this PR — the dispatch authorization gate blocks bot-authored PRs (tracked in dispatch: ADR 0054 authorization gate blocks review dispatch for coder-bot PRs #2674)
  2. ADR number collision detection is still missing — PR docs(adr): add ADR for dispatch version-skew resolution #2453 showed the agent completely missed ADR number collisions that humans rated HIGH, and PR fix(#2856): calibrate ADR convention violation severities in review agent #2857's fix does not address this gap

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Agent PR ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review agent should rate ADR convention violations at medium+ severity

1 participant