fix(compose): drop orphan projectName in ComposeBuild.run()#135
Open
chrisgeo wants to merge 1 commit into
Open
fix(compose): drop orphan projectName in ComposeBuild.run()#135chrisgeo wants to merge 1 commit into
chrisgeo wants to merge 1 commit into
Conversation
CHAOS-1436 Phase B unified `buildService` onto `extension ComposeCommand` with a 7-param signature that no longer takes `projectName` (image tags are now `service.image ?? "\(serviceName):latest"`). The local `let projectName = resolveProjectName(for: dockerCompose)` in `ComposeBuild.run()` survived as orphan code — Swift emits a `#no-usage` warning for it but doesn't fail the build. The remote path's separate `projectName` declaration (inside the `if RuntimeExecutionMode.isRemote` block) is unaffected — it's used immediately by `remoteBuild(projectName:)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleans up an unused
let projectName = resolveProjectName(for: dockerCompose)declaration inComposeBuild.run()(line 93). Triggered a#no-usagewarning on every build.Why it existed
CHAOS-1436 Phase B unified the three
buildServiceimplementations (acrossComposeUp,ComposeBuild,ComposeCreate) ontoextension ComposeCommandwith a new 7-param signature that no longer takesprojectName— image tags becameservice.image ?? "\(serviceName):latest". The orphan declaration inComposeBuildsurvived because Swift only warns on unusedletbindings; the build still succeeded.Scope check
projectNamedeclaration (inside theif RuntimeExecutionMode.isRemoteblock, line 86) is untouched — it's used immediately byremoteBuild(projectName:).ComposeBuildreferenceprojectNamefrom this scope.Test plan
swift buildclean — warning goneswift test --skip Container-Compose-DynamicTests --experimental-event-stream-output ... --filter "ComposeBuild|BuildConfiguration|RuntimeBuildPull"— 38 passed, 0 failed, 0 skipped (1 environmental XPC-timeout suite-level issue, unrelated)