QOL changes by vasilky3 · Pull Request #32 · fugkco/script.elementum.jackett

vasilky3 · 2024-03-06T15:06:08Z

Only one thread compare to old version. Coroutines used here
search trackers separately + visualisation
smart search for TVSeries. Can make multiple searches for more accurate result. Can use season names. Can find seasons in ranges e.g. [2 to 8] === 4
Progress bar + async trackers requesting
Added extra info to TV-search requests on the elementum side. Proceed it for more accurate result e.g. show_year, season_year, ep_year.
fix double prints
fix resolution mises, made it less strict.

Smart filter for TV search. Works much accurate but slower, can be disabled in settings.
Works better with elgatito/elementum#86 and elgatito/elementum#87

Main idea is search lots of torrent using title only. Filter this data using show_year, season_year, episode_year, season, episode, absolute_episode_number,season_name. Moreover filter looks for ranges in names e.g.: filter for ep 132 will return torrent 'Naruto [1-524]'. Same logic for years and seasons.

… only one thread. add dialog helper to see awaited indexers and progress rewrite client to be async remove uninformative p_dialog loadig from socket progress (~instant) add async request + async magnet resolve. add more informative p_dialog fix kodi bug with cpp-asyncio + win python 3.8-3.9 bug add aiohttp to poetry remove poetry request lib add translations small FLAKE8 warn fixes

…_ep_year

fugkco

That's a lot of changes! Generally, mostly looks good. I'll have to test it out but won't be able to until next week or so.

fugkco · 2024-03-06T22:46:29Z

+    ('720p', [r'720[p]', r'1280x720', r'hd720p?', r'hd\-?rip', r'b[rd]rip', r'xvid', r'dvd', r'dvdrip', r'hdtv',
+              r'web\-(dl)?rip', r'iptv']),
+    ('480p', [r'480[p]', r'sat\-?rip', r'tv\-?rip']),


Are there any examples for these? dvd is usually 480p or less. Not 720p. I see hdtv as the only one correctly moved option (in that, hdtv should be 720p). DVD/rip/xvid doesn't feel like it should be there.

You right DVD is 480p by default. I can fit 720p on DVD, but it's not native.

Xvid is a compression method, it can be 480p or 720p or 1080p. Am I wrong?
So I want this filter to be positive.

I don't think it's about what one can do, it's about what the release scene does generally. I've never seen a xvid/dvd/dvdrip contain 720p content. I'd rather have this reverted.

vasilky3 · 2024-03-07T01:28:19Z

That's a lot of changes! Generally, mostly looks good. I'll have to test it out but won't be able to until next week or so.

Shure I was trying to make changes in a smaller PR.
But the waiting time was too long.
You can download version from my fork release section if you need.

fugkco

Sorry for the late review. Overall I think these are some great changes. I have a few questions and changes. If you don't feel like implementing the changes, I can make them myself!

fugkco · 2024-04-13T13:22:57Z

              --repo="$GITHUB_REPOSITORY" \
              --title="${{github.ref_name}}" \
              --generate-notes \
-              build/script.elementum.jackett.zip


I'm not a big fan of this to be honest. The version is already in the GitHub URL when downloading. Is there a good reason for this?

yes, downloaded zip need to be different. I can't rollback the version because i will overwrite the old one, with the same name file.
For example. Any *.rpm package has a version in name, while it also in repo and inside the package itself.
I added it because was straggling, not knowing which version is which on my media centre.

What do you mean you can't rollback the version? The version is inside the addon.xml anyway?

I'm not sure why I wrote "can't". I can, but I need a reason.
I explained my reasoning:

World best practice. It's crucial for me.

Ability to store multiple versions on disc, no need to rename.

If I remember correctly, @elgatito told it's crucial for storing artifacts in Kodi repository.

I didn't understand your reasons.

fugkco · 2024-04-13T13:25:54Z

+            filtered.append(res)
+            continue
+
+        season_pattern = r"\W(?P<s_flag>s|season|сезон|tv-?|тв-?)[\s\(\[\{]*(?P<from>\d+)(?:\s*-\s*(?P<to>\d+))?"


I appreciate you're adding your own language, but we'd have to add other languages here too. Often these languages wouldn't be something a user wants. I'm wondering what the right solution would be here. Maybe an additional config option?

yes you are right. I thought it was "not good enough". But code became better and i pointed place for langspecific string.
I thing the best way will be to use existing method with https://github.com/fugkco/script.elementum.jackett/tree/master/resources/language
and adding config property like: Extra language for torrent filtering
Not sure if it possible to have multiple language packs. I want to have interface in English, while filters also using my native language.

I was just a little bit tired to do this. And not sure if it's the best method.

fugkco · 2024-04-13T13:27:10Z

+
+        if not global_ep:
+            continue
+        episode_pattern = r"(?:e?(?P<from>\d+)(?:\s*-\s*e?(?P<to>\d+)))|(?P<last>\d+)(?:\s*\+\s*\d*)?(?:\s*(из|of)\s*(?P<all>\d+))"


Same here w.r.t. the language search

you want me to change/remove this?
Or can i ask you to make a better implementation in the next PR?

fugkco · 2024-04-13T13:38:43Z

+    ('720p', [r'720[p]', r'1280x720', r'hd720p?', r'hd\-?rip', r'b[rd]rip', r'xvid', r'dvd', r'dvdrip', r'hdtv',
+              r'web\-(dl)?rip', r'iptv']),
+    ('480p', [r'480[p]', r'sat\-?rip', r'tv\-?rip']),


I don't think it's about what one can do, it's about what the release scene does generally. I've never seen a xvid/dvd/dvdrip contain 720p content. I'd rather have this reverted.

vasilky3 · 2024-04-14T17:06:50Z

@fugkco, is this your change request on conflict?
I'm not familiar with it, you want me to rebase?

vasilky3 · 2024-04-14T17:37:24Z

added small fix, to handle timeout in case tracker temporary unavailable

fugkco · 2024-10-29T16:36:42Z

Hey @vasilky3, sorry for this taking so long. I've been very busy. I'm hoping the look at this properly soon.

Otherwise: `TypeError: object of type 'coroutine' has no len()`

Fix versioning in Makefile for addon.xlm

vasilky3 and others added 9 commits December 29, 2023 23:56

fix double log printing

48d441b

fix resolution type

8c0b2b8

smart filter: add 'tv-' to regex

b8d60b9

Update publish.yml

1daa544

add version to released zip

910a11a

Fix crash resp wrong method call. And error on no response from tracker.

52fed81

Search tv series 4 times name, name_show_year, name_season_year, name…

85e71ce

…_ep_year

fugkco reviewed Mar 6, 2024

View reviewed changes

fugkco suggested changes Apr 13, 2024

View reviewed changes

handle timeout in search

8329197

handle timeout search fixes

ad7cb05

vasilky3 mentioned this pull request Oct 29, 2024

Fix log 'Skipped 1 duplicate messages..' #24

Open

antonsoroko and others added 3 commits April 25, 2025 00:28

Fix "general" search.

bb084b0

Otherwise: `TypeError: object of type 'coroutine' has no len()`

Version 3.1.0

21d9f50

Fix versioning in Makefile for addon.xlm

fix poetry export

4065831

Conversation

vasilky3 commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fugkco left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vasilky3 Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vasilky3 commented Mar 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fugkco left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vasilky3 Apr 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vasilky3 Apr 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vasilky3 Apr 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vasilky3 commented Apr 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vasilky3 commented Apr 14, 2024

Uh oh!

fugkco commented Oct 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vasilky3 commented Mar 6, 2024 •

edited

Loading

vasilky3 Mar 7, 2024 •

edited

Loading

vasilky3 commented Mar 7, 2024 •

edited

Loading

vasilky3 Apr 14, 2024 •

edited

Loading

vasilky3 Apr 14, 2024 •

edited

Loading

vasilky3 Apr 14, 2024 •

edited

Loading

vasilky3 commented Apr 14, 2024 •

edited

Loading