Fix hints bug when different records are treated as equal#866
Merged
Conversation
For records with different data.
webwarrior-ws
force-pushed
the
fix-hints-bug
branch
from
f05ad58 to
dccf2cc
Compare
Made getHashCode take into account inner expressions of record expressions. This is needed because record is treated as a single leaf node in FSharpLint AST and hint matcher compares only hashes of ast nodes. Function getHashCode was refactored to make it tail-recursive, as now it has to analyze inner expressions.
webwarrior-ws
force-pushed
the
fix-hints-bug
branch
from
f05ad58 to
02fe4bb
Compare
knocte
reviewed
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made
getHashCodetake into account inner expressions of record expressions. This is needed because record is treated as a single leaf node in FSharpLint AST and hint matcher compares only hashes of ast nodes.Function
getHashCodewas refactored to make it tail-recursive, as now it has to analyze inner expressions.