Skip to content

Add batch member confirmation system (preregistering members) - #314

Merged
georgelgeback merged 5 commits into
mainfrom
batch-member-confirm
Aug 14, 2026
Merged

Add batch member confirmation system (preregistering members)#314
georgelgeback merged 5 commits into
mainfrom
batch-member-confirm

Conversation

@georgelgeback

@georgelgeback georgelgeback commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Changes:

  • Adding batch members with multiple different identifiers
  • New tab pre-filtered on this to automatically accept members who have been pre-registered

Requires the following backend PR to be merged before tests have any chance to pass:

…ing members easier, add some missing translations, fix broken member edit form
@georgelgeback
georgelgeback requested a review from Copilot June 30, 2026 16:57

This comment was marked as outdated.

…. Better errors for fully empty or trailing fields. Fix batch add not clearing properly. Add missing translation key
@maffe03

maffe03 commented Aug 14, 2026

Copy link
Copy Markdown
Member

Från copilot (local):

Potential Areas to Review:

  • The batch input format (complex vs. simple) is inferred from semicolon presence—ensure this is intuitive for end users
  • Phone number validation uses Swedish region—confirm this is the desired behavior
  • Consider adding unit tests for handleBatchAdd validation logic
  • The STIL ID regex pattern (/^[a-z]{2}\d{4}[a-z]{2}-s$/) should be documented or explained

Recommendation
Ready for review with the understanding that backend integration is pending. All frontend type checking passes and the implementation is well-structured.

@maffe03 maffe03 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgelgeback
georgelgeback merged commit 5205362 into main Aug 14, 2026
1 check passed
@georgelgeback
georgelgeback deleted the batch-member-confirm branch August 14, 2026 16:06
hannesblaman pushed a commit that referenced this pull request Aug 17, 2026
* Add new tabs for managing preregistrations of members to make confirming members easier, add some missing translations, fix broken member edit form

* Better phone number parser which doesn't fire on stil-id with numbers. Better errors for fully empty or trailing fields. Fix batch add not clearing properly. Add missing translation key

* dummy commit

* Add stil-id comment and force stil-id to be lowercase instead of failing a batch add

---------

Co-authored-by: Manfred Malmros <manfred.malmros@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants