Nollning 26 quest screen - #337
Open
Knazeball wants to merge 6 commits into
Open
Conversation
… 2026 including leaderboard.
…placement. And removed some of my swedish comments that are not really necessary lol
…d the colour scheme on failed/completed/reviewed quests to make it more intuitive, tested different scenarios, changed sizes slightly, tested every pixel art.
Contributor
|
Looks good! I added an alertdialog so people can not enter the page when we release the app, if anyone else wants to look at the page, go to line 85 in |
marksam32
reviewed
Aug 18, 2026
| Map<NollningGroupRead, int> groupPointsMap = {}; | ||
| NollningRead? nollning; | ||
|
|
||
| String avklarad = "assets/data/nollning_25/uppdrag/bricka-avklarad.png"; |
Contributor
There was a problem hiding this comment.
Maybe we should copy required files from nollning_25 to nollning_26 since we're later removing nollning_25 from pubspec?
marksam32
reviewed
Aug 18, 2026
Contributor
There was a problem hiding this comment.
The font consolas already exists in the nollning branch.
marksam32
reviewed
Aug 18, 2026
| : "The quests will be released soon! (but not yet)"), | ||
| actions: [ | ||
| TextButton( | ||
| onPressed: () => setState(() { |
Contributor
There was a problem hiding this comment.
I don't think there is a need to setState a navigation pop.
Contributor
There was a problem hiding this comment.
Yeah that's fair. I copied it from the quests page I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this pull request contains:
What this doesn't contain:
I was unsure what to do about missions that are under "review". I decided to place them under "completed", but not have a checkmark. Idk if that is confusing but otherwise they would not be visible at all the next week.
Colour scheme for quests (this wasn't super clear from the grafikfös, but I think this works good):
I hope the code is not super ugly, I copied everything from last year and then changed as needed. Perfect order of operations lol