Implement new UKU firmware humidity thresholds#22
Merged
Conversation
vincentwolsink
force-pushed
the
humidity_logic
branch
from
b7bc54a to
3f1bf23
Compare
vincentwolsink
changed the title
Collaborator
Author
|
@frwickst Can you please publish the new release to pypi? |
Owner
|
@vincentwolsink I'm on vacation at the moment without my computer. I will not be able to publish before the 3rd of July. But I can give you access to the PyPi repo if you have an account there. |
Collaborator
Author
|
@frwickst My pypi account is also vincentwolsink. Thanks and enjoy your holiday! ☀️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added a helper function to check the max humidity for a temperature. Useful in Home Assistant for example.
The API itself will not properly handle these thresholds. It will either accept the request but set humidity to 0 silently. Or, when a humidity is not explicitly supplied but the current value is higher than the new temperature threshold, it will keep the current humidity value although the sauna controller itself lowered it.