docs: state MIT license directly and fix traf repo links - #94
Conversation
The License section deferred to "the original traf project" rather than naming a license, even though the repo ships an MIT LICENSE file and declares MIT in both package.json and Cargo.toml. The traf links used the npm scope form (github.com/@lemonade-hq/traf), which 404s - GitHub org paths carry no @.
|
Warning Review limit reached
Next review available in: 14 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📦 Preview Release AvailableA preview release has been published for commit 35ef569. Installationnpm install https://github.com/frontops-dev/domino/releases/download/pr-94-35ef569/front-ops-domino-2.0.2.tgzRunning the previewnpx https://github.com/frontops-dev/domino/releases/download/pr-94-35ef569/front-ops-domino-2.0.2.tgz affectedDetails |
2 participants
Problem
Two issues in the README:
License section deferred to another project — "Same as the original traf project." — instead of naming a license. That is unverifiable from this repo alone, and it disagreed with the three places that do declare it: the
LICENSEfile (MIT, © frontops.dev),"license": "MIT"inpackage.json, andlicense = "MIT"inCargo.toml.Broken traf links. Both references used the npm scope form
https://github.com/@lemonade-hq/traf. GitHub org paths carry no@, so the links 404. This appeared twice — Overview (line 14) and Credits (line 239).Solution
MIT - see [LICENSE](LICENSE)., pointing at the file already in the repo.https://github.com/lemonade-hq/traf.Key changes
README.mdOverviewgithub.com/@lemonade-hq/trafgithub.com/lemonade-hq/trafREADME.mdLicenseSame as the original traf project.MIT - see [LICENSE](LICENSE).README.mdCreditsgithub.com/@lemonade-hq/trafgithub.com/lemonade-hq/trafTesting
curl -o /dev/null -w '%{http_code}' https://github.com/lemonade-hq/traf→200.LICENSE,package.json, andCargo.toml.cargo fmt --check,cargo clippy -D warnings,prettiervia lint-staged) passed; prettier introduced no incidental reformatting.Docs-only change — no code paths touched, so no test adjustments were needed.
Breaking changes
None.